Skip to content

Fix property names to match erspec v0.2.0-rc.2 snake_case convention#7

Draft
Copilot wants to merge 4 commits intofeature/ERE1-123from
copilot/sub-pr-4
Draft

Fix property names to match erspec v0.2.0-rc.2 snake_case convention#7
Copilot wants to merge 4 commits intofeature/ERE1-123from
copilot/sub-pr-4

Conversation

Copy link

Copilot AI commented Feb 26, 2026

The codebase used camelCase property names (ereRequestId, errorTitle) but erspec v0.2.0-rc.2 defines all model properties in snake_case (ere_request_id, error_title). This caused Pydantic validation errors at runtime.

Changes

Source code

  • src/ere/adapters/mock_resolver.py - EREErrorResponse construction
  • src/ere/services/redis.py - Request/response ID logging
  • src/ere/adapters/redis.py - Client logging

Test infrastructure

  • Restored test/ere_test/__init__.py module
  • Updated imports: ere.modelserspec.models.{ere,core}
  • Fixed AbstractClient import path
  • Disabled FullRebuildRequest/Response (not yet in erspec)

Property mappings

# Before
EREErrorResponse(
    ereRequestId=request_id,
    errorTitle="Error",
    errorDetail="Details",
    errorType="ValueError"
)

# After
EREErrorResponse(
    ere_request_id=request_id,
    error_title="Error",
    error_detail="Details",
    error_type="ValueError"
)

ClusterReference(
    clusterId=id,
    confidenceScore=0.98
)
# After
ClusterReference(
    cluster_id=id,
    confidence_score=0.98,
    similarity_score=0.98  # now required
)

All property references now align with erspec model definitions.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits February 26, 2026 08:14
….2.0-rc.2

Co-authored-by: gkostkowski <12532923+gkostkowski@users.noreply.github.com>
Co-authored-by: gkostkowski <12532923+gkostkowski@users.noreply.github.com>
…erties to snake_case

Co-authored-by: gkostkowski <12532923+gkostkowski@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 26, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • install.python-poetry.org
    • Triggering command: /usr/bin/curl curl -sSL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update Docker-based infrastructure to fix property names Fix property names to match erspec v0.2.0-rc.2 snake_case convention Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants